On Tue, Jul 22, 2014 at 11:52:02AM +0300, Julian Anastasov wrote: > > > - if (copylen > 128) > > > + if (*len < (int) copylen || *len < 0) { > > > + pr_err("get_ctl: len %d < %u\n", *len, copylen); > > > > Don't let users flood dmesg. Just return an error. (This can be > > triggered by non-root as well). > > For now both set and get are privileged operations, > so we can keep it, it can catch if something wrong happens > with the structure sizes. If you have namespaces enabled then it's not *that* privaleged. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html