Acked-by: Dimitri Sivanich <sivanich@xxxxxxx> On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote: > [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if > unsigned variable 'gid' is less than zero. > > if (req.gid >= gru_max_gids || req.gid < 0) > return -EINVAL; > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80461 > Reported-by: David Binderman <dcb314@xxxxxxxxxxx> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx> > --- > drivers/misc/sgi-gru/grukdump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c > index a3700a5..e0e0e7e 100644 > --- a/drivers/misc/sgi-gru/grukdump.c > +++ b/drivers/misc/sgi-gru/grukdump.c > @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg) > return -EFAULT; > > /* Currently, only dump by gid is implemented */ > - if (req.gid >= gru_max_gids || req.gid < 0) > + if (req.gid >= gru_max_gids) > return -EINVAL; > > gru = GID_TO_GRU(req.gid); > -- > 1.8.5.5 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
