On 17/07/14 16:58, Andrey Utkin wrote:
> [linux-3.16-rc5/arch/metag/kernel/cachepart.c:102]: (style) Checking if
> unsigned variable 'thread_cache_size' is less than zero.
>
> Source code is
>
> if (thread_cache_size < 0)
> pr_emerg("Can't read %s cache size\n",
> cache_type ? "DCACHE" : "ICACHE");
>
> but
>
> unsigned int thread_cache_size;
>
> Function get_thread_cache_size returns an error code
> as (unsigned int) -1.
>
> Changed get_thread_cache_size() to return signed int, and its result is stored
> into signed int variable.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80361
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
Thanks, applied!
Cheers
James
> ---
> arch/metag/kernel/cachepart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/metag/kernel/cachepart.c b/arch/metag/kernel/cachepart.c
> index 0a2385f..04b7d4f 100644
> --- a/arch/metag/kernel/cachepart.c
> +++ b/arch/metag/kernel/cachepart.c
> @@ -55,7 +55,7 @@ unsigned int get_global_icache_size(void)
> return (get_icache_size() * ((temp >> SYSC_xCPARTG_AND_S) + 1)) >> 4;
> }
>
> -static unsigned int get_thread_cache_size(unsigned int cache, int thread_id)
> +static int get_thread_cache_size(unsigned int cache, int thread_id)
> {
> unsigned int cache_size;
> unsigned int t_cache_part;
> @@ -94,7 +94,7 @@ static unsigned int get_thread_cache_size(unsigned int cache, int thread_id)
>
> void check_for_cache_aliasing(int thread_id)
> {
> - unsigned int thread_cache_size;
> + int thread_cache_size;
> unsigned int cache_type;
> for (cache_type = ICACHE; cache_type <= DCACHE; cache_type++) {
> thread_cache_size =
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
