Re: [PATCH 1/3] drivers/ata/pata_ep93xx.c: use signed int type for result of platform_get_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 17, 2014 at 03:13:23PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/ata/pata_ep93xx.c:929]: (style) Checking if unsigned
> variable 'irq' is less than zero.
> 
> Source code is
> 
>     irq = platform_get_irq(pdev, 0);
>     if (irq < 0) {
> 
> but
> 
>     unsigned int irq;
> 
> $ fgrep platform_get_irq `find . -name \*.h -print`
> ./include/linux/platform_device.h:extern int platform_get_irq(struct
> platform_device *, unsigned int);
> 
> Now using "int" type instead of "unsigned int" for "irq" variable.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80401
> Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>

Applied to libata/for-3.16-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux