Re: [patch] staging: iio/ad7291: fix error code in ad7291_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/06/14 20:22, Dan Carpenter wrote:
We should be returning a negative error code instead of success here.

This would have been detected by GCC, except that the "ret" variable was
initialized with a bogus value to disable GCC's uninitialized variable
warnings.  I've cleaned that up, as well.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied to the fixes-togreg branch of iio.git and cc'd to stable.

Thanks,

Jonathan

diff --git a/drivers/staging/iio/adc/ad7291.c b/drivers/staging/iio/adc/ad7291.c
index 357cef2..7194bd1 100644
--- a/drivers/staging/iio/adc/ad7291.c
+++ b/drivers/staging/iio/adc/ad7291.c
@@ -465,7 +465,7 @@ static int ad7291_probe(struct i2c_client *client,
  	struct ad7291_platform_data *pdata = client->dev.platform_data;
  	struct ad7291_chip_info *chip;
  	struct iio_dev *indio_dev;
-	int ret = 0;
+	int ret;

  	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
  	if (!indio_dev)
@@ -475,7 +475,7 @@ static int ad7291_probe(struct i2c_client *client,
  	if (pdata && pdata->use_external_ref) {
  		chip->reg = devm_regulator_get(&client->dev, "vref");
  		if (IS_ERR(chip->reg))
-			return ret;
+			return PTR_ERR(chip->reg);

  		ret = regulator_enable(chip->reg);
  		if (ret)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux