Am 11.06.2014 08:53, schrieb Dan Carpenter:
> The function returns a u8 so the -ENOMEM is truncated to a positive
> value. The caller tests for zero returns and treats them as an error
> so I have changed the -ENOMEM to 0.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 3b5bacd..5ebe33d 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -525,7 +525,7 @@ static u8 at91_adc_get_trigger_value_by_name(struct iio_dev *idev,
> idev->id,
> triggers[i].name);
> if (!name)
> - return -ENOMEM;
> + return 0;
>
> if (strcmp(trigger_name, name) == 0) {
> value = triggers[i].value;
hi Dan,
LXR says there is only 1 caller (and he is checking for ENOMON)
perhaps it is better to change the return value to int.
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
