Am 28.05.2014 11:11, schrieb Giedrius Rekasius:
> Local variable "box" gets assigned correct value when it is initialized.
> There is no need to assign the same value again.
>
> Signed-off-by: Giedrius Rekasius <giedrius.rekasius@xxxxxxxxx>
> ---
> arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index 65bbbea..8cbbb1b 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -3817,7 +3817,6 @@ static void uncore_pci_remove(struct pci_dev *pdev)
> struct intel_uncore_pmu *pmu;
> int i, cpu, phys_id = pcibus_to_physid[pdev->bus->number];
>
> - box = pci_get_drvdata(pdev);
> if (!box) {
> for (i = 0; i < UNCORE_EXTRA_PCI_DEV_MAX; i++) {
> if (extra_pci_dev[phys_id][i] == pdev) {
Just a remark,
for readability it is better to remove the other one.
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
