Am 26.05.2014 17:21, schrieb Benoit Taine:
> This issue was reported by coccicheck using the semantic patch
> at scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Benoit Taine <benoit.taine@xxxxxxx>
> ---
> Tested by compilation without errors.
>
> drivers/misc/vmw_vmci/vmci_datagram.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c b/drivers/misc/vmw_vmci/vmci_datagram.c
> index f3cdd90..d93b469 100644
> --- a/drivers/misc/vmw_vmci/vmci_datagram.c
> +++ b/drivers/misc/vmw_vmci/vmci_datagram.c
> @@ -276,11 +276,10 @@ static int dg_dispatch_as_host(u32 context_id, struct vmci_datagram *dg)
> }
>
> /* We make a copy to enqueue. */
> - new_dg = kmalloc(dg_size, GFP_KERNEL);
> + new_dg = kmemdup(dg, dg_size, GFP_KERNEL);
> if (new_dg == NULL)
> return VMCI_ERROR_NO_MEM;
i can not see much of the code but this looks like
new_dg=dg;
what is possible in c99.
re,
wh
>
> - memcpy(new_dg, dg, dg_size);
> retval = vmci_ctx_enqueue_datagram(dg->dst.context, new_dg);
> if (retval < VMCI_SUCCESS) {
> kfree(new_dg);
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
