Hello Uwe, On Mon, May 19, 2014 at 08:27:22AM +0200, Uwe Kleine-König wrote: > Hello Emil, > > thanks for your effort. > > On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote: > > This converts the imx camera allocation and initialization functions > > to use platform_device_register_full() thus simplifying the code. > > > > Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx> > > --- > > Only build tested, unfortunately I currently don't have the hardware. > > > > arch/arm/mach-imx/devices/platform-ipu-core.c | 43 +++++++++---------------- > > arch/arm/mach-imx/mach-mx31_3ds.c | 5 ++- > > arch/arm/mach-imx/mach-mx31moboard.c | 6 ++-- > > arch/arm/mach-imx/mach-mx35_3ds.c | 5 ++- > > arch/arm/mach-imx/mach-pcm037.c | 5 ++- > > 5 files changed, 23 insertions(+), 41 deletions(-) > > > > diff --git a/arch/arm/mach-imx/devices/platform-ipu-core.c b/arch/arm/mach-imx/devices/platform-ipu-core.c > > index 6bd7c3f..13ea542 100644 > > --- a/arch/arm/mach-imx/devices/platform-ipu-core.c > > +++ b/arch/arm/mach-imx/devices/platform-ipu-core.c > > @@ -69,42 +69,29 @@ struct platform_device *__init imx_alloc_mx3_camera( > IMHO you should better rename the function because now it doesn't only > allocate the device, but also registers it. > > Also I doubt that it's OK to call dma_declare_coherent_memory after the > device is added. In this case maybe extend > platform_device_register_full? And also add a warning to > dma_declare_coherent_memory if it is called for an already added device? > (Added a few people to Cc: that might be able to comment this. I don't > even know if there is a reliable way to check if a device is already > added.) According to the documentation dma_declare_coherent_memory() is only used in unlikely corner cases, so I concluded that it is probably better not to include it in platform_device_register_full(). Best regards, Emil Goode -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
