On Fri, May 09, 2014 at 02:55:38PM +0300, Dan Carpenter wrote:
> We should return -ENOMEM if the kzalloc() fails instead of returning
> -ENOMEM.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
> index 71ce315..8dac6c5 100644
> --- a/sound/soc/codecs/wm0010.c
> +++ b/sound/soc/codecs/wm0010.c
> @@ -682,6 +682,7 @@ static int wm0010_boot(struct snd_soc_codec *codec)
> if (!img_swap) {
> dev_err(codec->dev,
> "Failed to allocate image buffer\n");
> + ret = -ENOMEM;
No need to set this here, it is set 12 lines earlier. I agree the
current code is not the most clear, but this patch is superfluous
with the current state of the code.
Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
