Ok, thanks, that's better. I'll put your modifications in the patch v3. ----- Mail original ----- De: "Ingo Molnar" <mingo@xxxxxxxxxx> À: "Tony Luck" <tony.luck@xxxxxxxxx> Cc: "Mathieu Souchaud" <mattieu.souchaud@xxxxxxx>, bp@xxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx Envoyé: Mardi 6 Mai 2014 08:27:10 Objet: Re: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling * Luck, Tony <tony.luck@xxxxxxxxx> wrote: > +err_device_create: > + /* > + * mce_device_remove behave properly if mce_device_create was not > + * called on that device. > + */ > + for_each_possible_cpu(i) > + mce_device_remove(i); > > grammar comment "s/behave/behaves/" > > Though perhaps this is better: > > /* > * We didn't keep track of which devices were created above, but > * even if we had, the set of online cpus might have changed. > * Play safe and remove for every possible cpu since mce_device_remove() > * will do the right thing. > */ and I guess: s/cpu since/cpu, since/ ? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
