On Sun, May 04, 2014 at 08:59:08PM +0200, walter harms wrote:
> > @@ -1051,12 +1054,13 @@ tx_b_frame(struct hfc4s8s_btype *bch)
> > cnt -= 4;
> > }
> >
> > - while (cnt--)
> > + while (cnt--) {
> > #ifdef HISAX_HFC4S8S_PCIMEM
> > fWrite_hfc8(l1->hw, A_FIFO_DATA0, *cp++);
> > #else
> > - fWrite_hfc8(l1->hw, *cp++);
> > + fWrite_hfc8(l1->hw, *cp++);
> > #endif
> > + }
>
> This looks wrong. The read above uses Read_hfc8/fRead_hfc8 (easy to
> confuse but i am not the maintainer ....)
> here we have 2* fWrite_hfc8() ?
> Does this compile with HISAX_HFC4S8S_PCIMEM ??
>
Yeah. You're right. The first fWrite_hfc8() should be Write_hfc8().
This same mistake is made two other places which prevents the driver
from compiling with HISAX_HFC4S8S_PCIMEM.
I will just delete this code since it has been broken since 2.6.12.
Let me resend.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
