On Tue, Jan 28, 2014 at 10:28 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > Is it ever valid to have pixclock, xres_virtual, or bits_per_pixel be > zero? Seems like it'd be trivial to check for those in fb_set_var()? pixclock could be zero for some special fixed type of display that doesn't have timings. Hmm, you could use 1 for that. Are there any in-tree users? Anyway, the checker reported issues with specific drivers, not with the core, right? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html