James, This patch seem to be fine. Please consider this patch. Regards, Sreekanth >-----Original Message----- >From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] >Sent: Friday, March 28, 2014 2:09 PM >To: Nandigama, Nagalakshmi >Cc: Reddy, Sreekanth; Support; James E.J. Bottomley; DL-MPT Fusion Linux; >linux-scsi@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx >Subject: [patch] [SCSI] mpt3sas: tidy up output slightly > >The indenting here for "pr_info("\n");" is not correct. It's not part of the if >condition. > >Also using pr_info() would put extra characters in the middle of the line. I >suppose that people could complain that pr_cont() is racy but at least it's >better than the original code. > >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > >diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c >b/drivers/scsi/mpt3sas/mpt3sas_base.c >index 0cf4f70..aa0e042 100644 >--- a/drivers/scsi/mpt3sas/mpt3sas_base.c >+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c >@@ -585,9 +585,9 @@ _base_display_event_data(struct MPT3SAS_ADAPTER >*ioc, > (event_data->ReasonCode == >MPI2_EVENT_SAS_DISC_RC_STARTED) ? > "start" : "stop"); > if (event_data->DiscoveryStatus) >- pr_info("discovery_status(0x%08x)", >+ pr_cont("discovery_status(0x%08x)", > le32_to_cpu(event_data->DiscoveryStatus)); >- pr_info("\n"); >+ pr_cont("\n"); > return; > } > case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE: -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
