Re: [PATCH] Staging: crystalhd: Mark local functions as static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar <prtvar.b@xxxxxxxxx> wrote:
> On Sat, Apr 19, 2014 at 1:23 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote:
>>> This fixes the following sparse warnings:
>>> drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should it be static?
>>> drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning: symbol 'chd_dec_pci_resume' was not declared. Should it be static?
>>> drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static?
>>> drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static?
>>>
>>> Signed-off-by: Bojan Prtvar <prtvar.b@xxxxxxxxx>
>>> ---
>>>  drivers/staging/crystalhd/crystalhd_lnx.c |   10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> This patch doesn't apply to my tree, can you redo it and resend?
>>
>> thanks,
>>
>> greg k-h
>
> I cloned your tree
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> and on master branch I see work is already done in
>
> commit 038d3f882926bf49562e5f119957fd81015a9390
> Author: Valentina Manea <valentina.manea.m@xxxxxxxxx>
> Date:   Mon Oct 7 23:12:14 2013 +0300
>
> Now what confuses me is the date of this patch. Why I didn't see it
> linux-next and even in vanilla?
> I know this question goes under 'basic workflow section'.
>
> Regards,
> Bojan

I re-checked. Everything is OK with  038d3f8829. I made a mess in my
local branches.
Drop this one. And sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux