merged into cifs-2.6.git for-next
On Thu, Apr 3, 2014 at 5:05 PM, Cyril Roelandt <tipecaml@xxxxxxxxx> wrote:
> In SMB2_set_compression(), the "res_key" variable is only initialized to NULL
> and later kfreed. It is therefore useless and should be removed.
>
> Found with the following semantic patch:
>
> <smpl>
> @@
> identifier foo;
> identifier f;
> type T;
> @@
> * f(...) {
> ...
> * T *foo = NULL;
> ... when forall
> when != foo
> * kfree(foo);
> ...
> }
> </smpl>
>
> Signed-off-by: Cyril Roelandt <tipecaml@xxxxxxxxx>
> ---
> fs/cifs/smb2pdu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index 8603447..3802f8c 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -1352,7 +1352,6 @@ SMB2_set_compression(const unsigned int xid, struct cifs_tcon *tcon,
> u64 persistent_fid, u64 volatile_fid)
> {
> int rc;
> - char *res_key = NULL;
> struct compress_ioctl fsctl_input;
> char *ret_data = NULL;
>
> @@ -1365,7 +1364,6 @@ SMB2_set_compression(const unsigned int xid, struct cifs_tcon *tcon,
> 2 /* in data len */, &ret_data /* out data */, NULL);
>
> cifs_dbg(FYI, "set compression rc %d\n", rc);
> - kfree(res_key);
>
> return rc;
> }
> --
> 1.9.1
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
