On Wed, 26 Mar 2014, Eric Dumazet wrote: > On Wed, 2014-03-26 at 22:33 +0100, Julia Lawall wrote: > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > > diff --git a/net/atm/mpc.c b/net/atm/mpc.c > > index b71ff6b..91dc58f 100644 > > --- a/net/atm/mpc.c > > +++ b/net/atm/mpc.c > > @@ -1492,7 +1492,7 @@ static void __exit atm_mpoa_cleanup(void) > > > > mpc_proc_clean(); > > > > - del_timer(&mpc_timer); > > + del_timer_sync(&mpc_timer); > > unregister_netdevice_notifier(&mpoa_notifier); > > deregister_atm_ioctl(&atm_ioctl_ops); > > > > It seems this timer rearms itself, so this patch wont be enough I fear. That's why you need del_timer_sync() it waits for the timer handler to complete and then removes it. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
