Re: [patch v2] [patch] [media] em28xx-cards: remove a wrong indent level

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 05.03.2014 12:09, schrieb Dan Carpenter:
> This code is correct but the indenting is wrong and triggers a static
> checker warning "add curly braces?".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> v2: in v1 I added curly braces.
>
> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> index 4d97a76cc3b0..33f06ffec4b2 100644
> --- a/drivers/media/usb/em28xx/em28xx-cards.c
> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> @@ -3331,8 +3331,8 @@ static int em28xx_usb_probe(struct usb_interface *interface,
>  	if (has_video) {
>  	    if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
>  		dev->analog_xfer_bulk = 1;
> -		em28xx_info("analog set to %s mode.\n",
> -			    dev->analog_xfer_bulk ? "bulk" : "isoc");
> +	    em28xx_info("analog set to %s mode.\n",
> +			dev->analog_xfer_bulk ? "bulk" : "isoc");

Instead of moving em28xx_info(...) to the left the if section needs to
be moved to the right:

- 	    if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
- 		dev->analog_xfer_bulk = 1;
+ 		if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
+ 			dev->analog_xfer_bulk = 1;

While you are at it, could you also do fix the indention in the next
paragraph ?
Thanks !

Regards,
Frank

>  	}
>  	if (has_dvb) {
>  	    if (!dev->dvb_ep_isoc || (try_bulk && dev->dvb_ep_bulk))
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux