On Tue 25-02-14 11:39:45, Dan Carpenter wrote: > We know "fatal" is zero here. The code can be simplified a bit by > assigning directly. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks. Added to my tree. Honza > > diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c > index 22548f56197b..158b5d4ce067 100644 > --- a/fs/ext3/balloc.c > +++ b/fs/ext3/balloc.c > @@ -1727,10 +1727,7 @@ allocated: > percpu_counter_sub(&sbi->s_freeblocks_counter, num); > > BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor"); > - err = ext3_journal_dirty_metadata(handle, gdp_bh); > - if (!fatal) > - fatal = err; > - > + fatal = ext3_journal_dirty_metadata(handle, gdp_bh); > if (fatal) > goto out; > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
