From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Data: Friday, February 21, 2014 4:55 PM >To: Dmitry Torokhov >Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel Kurtz; >linux-input@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx >Subject: [patch] Input: remove a duplicative NULL test > >"pdata" is non-NULL here. We verified that at the start of the function. > >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > >diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c >b/drivers/input/touchscreen/atmel_mxt_ts.c >index a70400754e92..40abe90cc924 100644 >--- a/drivers/input/touchscreen/atmel_mxt_ts.c >+++ b/drivers/input/touchscreen/atmel_mxt_ts.c >@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client, > goto err_free_mem; > } > >- data->is_tp = pdata && pdata->is_tp; >+ data->is_tp = pdata->is_tp; > > input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" : > "Atmel maXTouch Touchscreen"; > Agree, it is redundant. And if you have free time, you can convert the driver to support devicetree. Acked-by: Fugang Duan <B38611@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
