On 13.02.2014 16:58, Dan Carpenter wrote: > We checked "nbytes < bsize" before so it can't happen here. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Jussi Kivilinna <jussi.kivilinna@xxxxxx> > --- > This doesn't change how the code works, but maybe their is a bug in the > original code. Please review? > > diff --git a/arch/x86/crypto/cast5_avx_glue.c b/arch/x86/crypto/cast5_avx_glue.c > index e6a3700489b9..e57e20ab5e0b 100644 > --- a/arch/x86/crypto/cast5_avx_glue.c > +++ b/arch/x86/crypto/cast5_avx_glue.c > @@ -203,9 +203,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, > src -= 1; > dst -= 1; > } while (nbytes >= bsize * CAST5_PARALLEL_BLOCKS); > - > - if (nbytes < bsize) > - goto done; > } > > /* Handle leftovers */ > diff --git a/arch/x86/crypto/blowfish_glue.c b/arch/x86/crypto/blowfish_glue.c > index 50ec333b70e6..8af519ed73d1 100644 > --- a/arch/x86/crypto/blowfish_glue.c > +++ b/arch/x86/crypto/blowfish_glue.c > @@ -223,9 +223,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, > src -= 1; > dst -= 1; > } while (nbytes >= bsize * 4); > - > - if (nbytes < bsize) > - goto done; > } > > /* Handle leftovers */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
