On 02/11/2014 05:03 PM, Dan Carpenter wrote: > There is a missing unlock on error here. > > Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > index 269b85cc875a..9fbbaaa9e541 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv, > if (dev_priv->has_mob) { > ret = vmw_rebind_contexts(sw_context); > if (unlikely(ret != 0)) > - goto out_err; > + goto out_unlock_binding; > } > > cmd = vmw_fifo_reserve(dev_priv, command_size); Dan, thanks, Reviewed-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx> Queued for next vmwgfx-fixes pull. /Thomas -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html