On Fri, Jan 31, 2014 at 04:18:51PM +1030, Rusty Russell wrote: > Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > > My static checker complains that: > > > > drivers/char/hw_random/core.c:341 hwrng_register() > > warn: we tested 'old_rng' before and it was 'false' > > > > The problem is that sometimes we test "if (!old_rng)" and sometimes we > > test "if (must_register_misc)". The static checker knows they are > > equivalent but a human being reading the code could easily be confused. > > > > I have simplified the code by removing the "must_register_misc" variable > > and I have removed the redundant check on "if (!old_rng)". > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Yeah, clearer too. > > Reviewed-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> Patch applied. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
