From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Wed, 5 Feb 2014 16:29:21 +0300 > In the original code, if tg3_readphy() fails then it does an unnecessary > check to verify "err" is still zero and then returns -EBUSY. > > My static checker complains about the unnecessary "if (!err)" check and > anyway it is better to propagate the -EBUSY error code from > tg3_readphy() instead of hard coding it here. And really the original > code is confusing to look at. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
