Hi Linus, Sekhar,
On 01/15/2014 09:21 AM, Linus Walleij wrote:
> On Thu, Jan 9, 2014 at 6:28 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
>> "irq" needs to be signed for the error handling to work.
>>
>> Fixes: 6075a8b2b6c3 ('gpio: davinci: don't create irq_domain in case of unbanked irqs')
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 7629b4f12b7f..b0e98d379217 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -423,7 +423,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
>>
>> static int davinci_gpio_irq_setup(struct platform_device *pdev)
>> {
>> - unsigned gpio, irq, bank;
>> + unsigned gpio, bank;
>> struct clk *clk;
>> u32 binten = 0;
>> unsigned ngpio, bank_irq;
>> @@ -433,6 +433,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>> struct davinci_gpio_platform_data *pdata = dev->platform_data;
>> struct davinci_gpio_regs __iomem *g;
>> struct irq_domain *irq_domain = NULL;
>> + int irq;
>>
>> ngpio = pdata->ngpio;
>> res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> This merge window the DaVinci GPIO changes are queued by the DaVinci
> maintainers (this patch does not even apply to my tree) so DaVinci guys:
> please pick up this patch.
This patch is not in 3.14 yet. Are there any chances to have it in 3.14,
as it introduces merge conflicts with future patches?
Also, this is a fix.
Regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
