On Tue, Jan 21, 2014 at 01:43:55PM +0100, walter harms wrote: > > i have just noticed: The function already exits > > 194 static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file) > 195 { > 196 if (!file->driver_priv) > 197 return; > 198 > 199 kfree(file->driver_priv); > 200 file->driver_priv = NULL; > 201 } The function is different in the current code. I glanced through drm_open_helper() and I don't see that file->driver_priv to NULL is needed anyway... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html