On 21/01/2014 07:52, Dan Carpenter wrote: > of_iomap() returns NULL on error, it doesn't return error pointers. > Hi Dan, Thanks for your patch but I already sent this fix yesterday and Jason have applied. See: http://thread.gmane.org/gmane.linux.ports.arm.kernel/295642 Thanks, Gregory > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c > index fe4fc1cbdfaf..b4cfbd62709d 100644 > --- a/arch/arm/mach-mvebu/mvebu-soc-id.c > +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c > @@ -88,7 +88,7 @@ static int __init mvebu_soc_id_init(void) > } > > pci_base = of_iomap(child, 0); > - if (IS_ERR(pci_base)) { > + if (!pci_base) { > pr_err("cannot map registers\n"); > ret = -ENOMEM; > goto res_ioremap; > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
