On Sun, Dec 29, 2013 at 11:47:23PM +0100, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Applied, thanks -- ~Vinod > > --- > Not tested. > > drivers/dma/cppi41.c | 4 +++- > drivers/dma/ppc4xx/adma.c | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > index c29dacf..c18aebf 100644 > --- a/drivers/dma/cppi41.c > +++ b/drivers/dma/cppi41.c > @@ -972,8 +972,10 @@ static int cppi41_dma_probe(struct platform_device *pdev) > goto err_chans; > > irq = irq_of_parse_and_map(dev->of_node, 0); > - if (!irq) > + if (!irq) { > + ret = -EINVAL; > goto err_irq; > + } > > cppi_writel(USBSS_IRQ_PD_COMP, cdd->usbss_mem + USBSS_IRQ_ENABLER); > > diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c > index 8bba298..ce7a8d7 100644 > --- a/drivers/dma/ppc4xx/adma.c > +++ b/drivers/dma/ppc4xx/adma.c > @@ -4114,6 +4114,7 @@ static int ppc440spe_adma_probe(struct platform_device *ofdev) > regs = ioremap(res.start, resource_size(&res)); > if (!regs) { > dev_err(&ofdev->dev, "failed to ioremap regs!\n"); > + ret = -ENOMEM; > goto err_regs_alloc; > } > > -- -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
