Hi Dan and Daniel, On Mon, Dec 16, 2013 at 12:45:44PM +0300, Dan Carpenter wrote: > There are several error paths which don't unlock on error. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks for the patch. However it seems this change has been already done by essentially similar patch (w/o the redundant rval check removal): commit eed8c3eebce72fe4fc766f9a23e4324b04bd86cf Author: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Date: Thu Nov 7 09:44:42 2013 -0300 [media] media: i2c: lm3560: fix missing unlock on error in lm3560_set_ctrl() Add the missing unlock before return from function lm3560_set_ctrl() in the error handling case. Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> This patch is in Mauro's tree already (and possibly elsewhere). -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html