> > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > > > The semantic patch that makes this change is as follows: > > > (http://coccinelle.lip6.fr/) > > > > > > // <smpl> > > > @@ > > > expression pdev; > > > @@ > > > > > > pci_set_power_state(pdev, > > > - 0 > > > + PCI_D0 > > > ) > > > // </smpl> > > > > I'm happy with the code and that you used Coccinelle to discover the > > issue, but I feel a little more explanation would be helpful to > > readers. > > > > Why is (pci_power_t __force) 0 better than 0? > > I wasn't particularly attached to the cast, and I don't know if it is an > issue. But in trying to understand the code, I found PCI_D0 more > understandable than 0. Well I don't want to waste any of your or my time, so I'll apply the patch and add something along those lines to the commit message. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
