On Sun, Dec 29, 2013 at 11:47 PM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > --- > Not tested. > > drivers/scsi/ps3rom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c > index e6e2a30..04d77ce 100644 > --- a/drivers/scsi/ps3rom.c > +++ b/drivers/scsi/ps3rom.c > @@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev) > if (!host) { > dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n", > __func__, __LINE__); > + error = -ENOMEM; > goto fail_teardown; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
