On 17/12/2013 13:57, Dan Carpenter wrote: > 838 if (ring->bf_enabled && desc_size <= MAX_BF && !bounce && !vlan_tx_tag_present(skb)) { > 839 *(__be32 *) (&tx_desc->ctrl.vlan_tag) |= cpu_to_be32(ring->doorbell_qpn); > > And then sometimes we overwrite them here. It's not clear if this is > deliberate or accidental. Maybe add a comment? Yes, this is deliberate. I will send a patch to make it clearer. Amir -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html