Re: [patch v2] spi: bcm63xx-hsspi: checking for ERR_PTR instead of NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 6, 2013 at 3:12 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> devm_request_and_ioremap() returns NULL on error, it doesn't return an
> ERR_PTR().  This patch fixes it by switching to devm_ioremap_resource()
> which is the prefered function anyway.
>
> Fixes: 142168eba9dc ('spi: bcm63xx-hsspi: add bcm63xx HSSPI driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks.

Acked-by: Jonas Gorski <jogo@xxxxxxxxxxx>


Jonas

> ---
> v2: switch to devm_ioremap_resource()
>
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index bc8d848d33b7..2cfe8eb619fd 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -338,7 +338,7 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>         }
>
>         res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       regs = devm_request_and_ioremap(dev, res_mem);
> +       regs = devm_ioremap_resource(dev, res_mem);
>         if (IS_ERR(regs))
>                 return PTR_ERR(regs);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux