re: null_blk: multi queue aware block test driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jens Axboe,

This is a semi-automatic email about new static checker warnings.

The patch f2298c0403b0: "null_blk: multi queue aware block test 
driver" from Oct 25, 2013, leads to the following Smatch complaint:

drivers/block/null_blk.c:524 null_add_dev()
	 warn: variable dereferenced before check 'nullb->q' (see line 523)

drivers/block/null_blk.c
   522			nullb->q = blk_init_queue_node(null_request_fn, &nullb->lock, home_node);
   523			blk_queue_prep_rq(nullb->q, null_rq_prep_fn);
                                          ^^^^^^^^
Dereference.

   524			if (nullb->q)
                            ^^^^^^^^
Null check.

   525				blk_queue_softirq_done(nullb->q, null_softirq_done_fn);
   526		}

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux