Fri, Nov 01, 2013 at 11:41:00AM CET, vfalico@xxxxxxxxxx wrote:
>On Fri, Nov 01, 2013 at 01:18:44PM +0300, Dan Carpenter wrote:
>>There is an extra semi-colon so bond_get_size() doesn't return the
>>correct value.
>>
>>Fixes: ec76aa49855f ('bonding: add Netlink support active_slave option')
>>Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
>Hrm, how does it even build. Good catch, thanks.
I wonder about the same thing.
Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxxx>
>
>Acked-by: Veaceslav Falico <vfalico@xxxxxxxxxx>
>
>>
>>diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
>>index 7661261..40e7b1c 100644
>>--- a/drivers/net/bonding/bond_netlink.c
>>+++ b/drivers/net/bonding/bond_netlink.c
>>@@ -82,8 +82,8 @@ static int bond_newlink(struct net *src_net, struct net_device *bond_dev,
>>
>>static size_t bond_get_size(const struct net_device *bond_dev)
>>{
>>- return nla_total_size(sizeof(u8)); /* IFLA_BOND_MODE */
>>- + nla_total_size(sizeof(u32)); /* IFLA_BOND_ACTIVE_SLAVE */
>>+ return nla_total_size(sizeof(u8)) + /* IFLA_BOND_MODE */
>>+ nla_total_size(sizeof(u32)); /* IFLA_BOND_ACTIVE_SLAVE */
>>}
>>
>>static int bond_fill_info(struct sk_buff *skb,
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
