On Thu, Oct 03, 2013 at 12:04:40PM +0530, Sagar Padhye wrote: > > > I checked that cpuidle_devices is only being used in cpuidle.c - hence > > > thought that it can be made static and be removed from header. > > > > "cpuidle_devices" is actually used in drivers/cpuidle/coupled.c as well > > so this breaks the build. > > Darn! I forgot 'clean build' part. sorry. > > > Even for "cpuidle_dev" the patch isn't right. It doesn't fix the > > warning, for me. The DEFINE_PER_CPU() macro defines several variables > > actually. Per CPU variables are a bit complicated and they have to have > > globally unique names. So just ignore the Sparse warning for per CPU > > variables. > > > > Ok, let me look at my sparse log once again, will pick some other > problem (any suggestions?) You're on the right track. Just the details are wrong. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
