On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin <peter.senna@xxxxxxxxx> wrote: > > The variable success is only assigned the values true and false. > Change its type to bool. > > The simplified semantic patch that find this problem is as > follows (http://coccinelle.lip6.fr/): > > @exists@ > type T; > identifier b; > @@ > - T > + bool > b = ...; > ... when any > b = \(true\|false\) > > Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > --- > drivers/scsi/isci/port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c > index 13098b0..26f8e5c 100644 > --- a/drivers/scsi/isci/port.c > +++ b/drivers/scsi/isci/port.c > @@ -174,7 +174,7 @@ static void isci_port_link_up(struct isci_host *isci_host, > { > unsigned long flags; > struct sci_port_properties properties; > - unsigned long success = true; > + bool success = true; > > dev_dbg(&isci_host->pdev->dev, > "%s: isci_port = %p\n", > -- > 1.8.3.1 Acked-by: Lukasz Dorau <lukasz.dorau@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html