We already dereferenced "skdev" a few lines earlier in the debug code so my static checker complains. I audited the callers and "skdev" is never NULL here so I have removed the check. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 20ad843..827f927 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -2909,7 +2909,7 @@ static void skd_do_inq_page_da(struct skd_device *skdev, inq.page_code = DRIVER_INQ_EVPD_PAGE_CODE; - if (skdev && skdev->pdev && skdev->pdev->bus) { + if (skdev->pdev && skdev->pdev->bus) { skd_get_link_info(skdev->pdev, &inq.pcie_link_speed, &inq.pcie_link_lanes); inq.pcie_bus_number = cpu_to_be16(skdev->pdev->bus->number); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html