Re: [PATCH] ACPICIA: kfree() NULL pointer cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 07, 2013 at 05:07:24PM +0200, Bojan Prtvar wrote:
> Checking for NULL pointers before kfree() is redundant.
>        error_exit:
> -	if (gpe_register_info) {
> -		ACPI_FREE(gpe_register_info);
> -	}
> -	if (gpe_event_info) {
> -		ACPI_FREE(gpe_event_info);
> -	}
> +	ACPI_FREE(gpe_register_info);
> +	ACPI_FREE(gpe_event_info);

This isn't right.  If you have certain debugging turned on then
ACPI_FREE() does not accept NULL pointers.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux