Re: [patch] ecryptfs: remove check for if an array is NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-07-31 12:10:10, Dan Carpenter wrote:
> It doesn't make sense to check if an array is NULL.  The compiler just
> removes the check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks, Dan!

I've pushed this to my next branch and it will be part of a pull request
that should go out early next week.

Tyler

> ---
> Or perhaps "if (!strlen(crypt_stat->cipher))" was intended?  I'm not
> very familiar with this code.
> 
> diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
> index d107576..3bd35e2 100644
> --- a/fs/ecryptfs/crypto.c
> +++ b/fs/ecryptfs/crypto.c
> @@ -609,10 +609,6 @@ int ecryptfs_init_crypt_ctx(struct ecryptfs_crypt_stat *crypt_stat)
>  	char *full_alg_name;
>  	int rc = -EINVAL;
>  
> -	if (!crypt_stat->cipher) {
> -		ecryptfs_printk(KERN_ERR, "No cipher specified\n");
> -		goto out;
> -	}
>  	ecryptfs_printk(KERN_DEBUG,
>  			"Initializing cipher [%s]; strlen = [%d]; "
>  			"key_size_bits = [%zd]\n",

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux