On Mon, 19 Aug 2013, Svenning Sørensen wrote: > On 19-08-2013 10:51, Julia Lawall wrote: > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > > index 4ffbaac..f2f9710 100644 > > --- a/drivers/usb/musb/musb_dsps.c > > +++ b/drivers/usb/musb/musb_dsps.c > > @@ -357,9 +357,6 @@ static int dsps_musb_init(struct musb *musb) > > u32 rev, val; > > r = platform_get_resource_byname(parent, IORESOURCE_MEM, "control"); > > - if (!r) > > - return -EINVAL; > > - > > reg_base = devm_ioremap_resource(dev, r); > > if (!musb->ctrl_base) > > return -EINVAL; > Not really related to Julia's patch, apart from making it more obvious that > there's a bug here. > I believe it is reg_base that needs to be checked, right? Indeed, it is all backwards. I could extend the patch, if you want. julia
