Am 19.08.2013 12:12, schrieb Julia Lawall: > On Mon, 19 Aug 2013, walter harms wrote: > >> >> >> Am 19.08.2013 10:51, schrieb Julia Lawall: >>> From: Julia Lawall <Julia.Lawall@xxxxxxx> >>> >>> Remove unneeded error handling on the result of a call to >>> platform_get_resource_byname when the value is passed to devm_ioremap_resource. >>> >>> A simplified version of the semantic patch that makes this change is as >>> follows: (http://coccinelle.lip6.fr/) >>> >>> // <smpl> >>> @@ >>> expression pdev,res,e,e1; >>> expression ret != 0; >>> identifier l; >>> @@ >>> >>> res = platform_get_resource_byname(...); >>> - if (res == NULL) { ... \(goto l;\|return ret;\) } >>> e = devm_ioremap_resource(e1, res); >>> // </smpl> >>> >>> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> >>> >>> --- >>> drivers/regulator/ti-abb-regulator.c | 10 ---------- >>> 1 file changed, 10 deletions(-) >>> >>> diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c >>> index 3753ed0..d8e3e12 100644 >>> --- a/drivers/regulator/ti-abb-regulator.c >>> +++ b/drivers/regulator/ti-abb-regulator.c >>> @@ -717,11 +717,6 @@ static int ti_abb_probe(struct platform_device *pdev) >>> /* Map ABB resources */ >>> pname = "base-address"; >>> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname); >>> - if (!res) { >>> - dev_err(dev, "Missing '%s' IO resource\n", pname); >>> - ret = -ENODEV; >>> - goto err; >>> - } >>> abb->base = devm_ioremap_resource(dev, res); >>> if (IS_ERR(abb->base)) { >>> ret = PTR_ERR(abb->base); >> >> >> is pname used by anything else ? (also below) > > I'm not sure to understand the sense of the question. My patch does > remove a use of pname, but there is another one on the line above, in the > call to platform_get_resource_byname. Perhaps the definition of pname > could be inlined at this use, but it is a common pattern throughout the > function. > in other functions this looks like that: r = platform_get_resource_byname(parent, IORESOURCE_MEM, "control"); i did not dive into the driver but from the part i see makeing this into: es = platform_get_resource_byname(pdev, IORESOURCE_MEM,"base-address"); would render pname obsolete. re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
