Hello, Dan.
On Fri, Aug 16, 2013 at 10:33:36AM +0300, Dan Carpenter wrote:
> @@ -347,9 +347,9 @@ static int highbank_initialize_phys(struct device *dev, void __iomem *addr)
> struct device_node *phy_nodes[CPHY_PHY_COUNT];
> u32 tx_atten[CPHY_PORT_COUNT];
>
> - memset(port_data, 0, sizeof(struct phy_lane_info) * CPHY_PORT_COUNT);
> - memset(phy_nodes, 0, sizeof(struct device_node*) * CPHY_PHY_COUNT);
> - memset(tx_atten, 0xff, CPHY_PORT_COUNT);
> + memset(port_data, 0, sizeof(port_data));
> + memset(phy_nodes, 0, sizeof(phy_nodes));
> + memset(tx_atten, 0xff, sizeof(tx_atten));
Ugh... why would anybody name a global variable port_data[]? So,
port_data is global and the other two are local. Wouldn't it be
better to just do "= { }" on declaration for the local ones?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
