On Wed, Aug 14, 2013 at 04:51:02PM +0530, Viresh Kumar wrote: > On Wed, Aug 14, 2013 at 4:33 PM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > Remove unneeded error handling on the result of a call to > > platform_get_resource when the value is passed to devm_ioremap_resource. > > > > Move the call to platform_get_resource adjacent to the call to > > devm_ioremap_resource to make the connection between them more clear. > > > > A simplified version of the semantic patch that makes this change is as > > follows: (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @@ > > expression pdev,res,n,e,e1; > > expression ret != 0; > > identifier l; > > @@ > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, n); > > ... when != res > > - if (res == NULL) { ... \(goto l;\|return ret;\) } > > ... when != res > > + res = platform_get_resource(pdev, IORESOURCE_MEM, n); > > e = devm_ioremap_resource(e1, res); > > // </smpl> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > --- > > > drivers/input/keyboard/spear-keyboard.c | 7 +------ > > For SPEAr: > > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Thanks, applied. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
