Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> We know that "dev" is a valid pointer at this point, so we can remove
> the test and clean up a little.
Quite right.
Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 618dbe4..e7e058e 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1867,10 +1867,10 @@ replay:
> else
> err = register_netdevice(dev);
>
> - if (err < 0 && !IS_ERR(dev))
> + if (err < 0) {
> free_netdev(dev);
> - if (err < 0)
> goto out;
> + }
>
> err = rtnl_configure_link(dev, ifm);
> if (err < 0)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
