Hi Dan, Agreed. Could you make a patch that covers other alloc_page cases too? # grep alloc_page fs/f2fs/* fs/f2fs/node.c: page = alloc_page(GFP_NOFS | __GFP_ZERO); fs/f2fs/recovery.c: page = alloc_page(GFP_F2FS_ZERO); fs/f2fs/recovery.c: page = alloc_page(GFP_NOFS | __GFP_ZERO); Thank you, 2013-08-14 (수), 14:41 +0300, Dan Carpenter: > alloc_page() returns a NULL on failure, it never returns an ERR_PTR. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index f5172e2..3e87fe0 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1515,8 +1515,8 @@ int restore_node_summary(struct f2fs_sb_info *sbi, > > /* alloc temporal page for read node */ > page = alloc_page(GFP_NOFS | __GFP_ZERO); > - if (IS_ERR(page)) > - return PTR_ERR(page); > + if (!page) > + return -ENOMEM; > lock_page(page); > > /* scan the node segment */ -- Jaegeuk Kim Samsung -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
