On Wed, Aug 14, 2013 at 2:41 PM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to devm_ioremap_resource. > > Move the call to platform_get_resource adjacent to the call to > devm_ioremap_resource to make the connection between them more clear. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression pdev,res,n,e,e1; > expression ret != 0; > identifier l; > @@ > > - res = platform_get_resource(pdev, IORESOURCE_MEM, n); > ... when != res > - if (res == NULL) { ... \(goto l;\|return ret;\) } > ... when != res > + res = platform_get_resource(pdev, IORESOURCE_MEM, n); > e = devm_ioremap_resource(e1, res); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > drivers/rtc/rtc-spear.c | 7 +------ > 3 files changed, 3 insertions(+), 12 deletions(-) For SPEAr: Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> > diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c > index c492cf0..6470641 100644 > --- a/drivers/rtc/rtc-spear.c > +++ b/drivers/rtc/rtc-spear.c > @@ -358,12 +358,6 @@ static int spear_rtc_probe(struct platform_device *pdev) > int status = 0; > int irq; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "no resource defined\n"); > - return -EBUSY; > - } > - > config = devm_kzalloc(&pdev->dev, sizeof(*config), GFP_KERNEL); > if (!config) { > dev_err(&pdev->dev, "out of memory\n"); > @@ -385,6 +379,7 @@ static int spear_rtc_probe(struct platform_device *pdev) > return status; > } > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > config->ioaddr = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(config->ioaddr)) > return PTR_ERR(config->ioaddr); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
