On Tue, Aug 13, 2013 at 02:23:02PM +0800, Huang Shijie wrote: > 于 2013年08月09日 17:49, Dan Carpenter 写道: > >There are static checkers which complain when we declare variables as > > could you tell me which "checker" and how do you test it? > > you'd better post the warning message here. > It's some stuff I'm working on but haven't released yet. But "len" and "ofs" are declared as u64 and loff_t. If they were declared as unsigned long then maybe the current code would be fine because the code would be correct-ish on 32 bit arches. So this is definitely the right thing to do. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
