On Sat, 2013-08-10 at 17:38 +0200, Julia Lawall wrote: > On Sat, 10 Aug 2013, Joe Perches wrote: > > On Sat, 2013-08-10 at 17:25 +0200, Julia Lawall wrote: > > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > > Because ARRAY_AND_SIZE changes the apparent arity of a function, if it is > > > used for one call to a given function, it would be better, if possible, to > > > use it for all of them. > > I think it'd be better to remove ARRAY_AND_SIZE instead. > > I can do that, if it is wanted, but there are over 200 uses, and I think > it is a little bit positive in that it ensures that the array is passed > along with its own size. Maybe, but if it's generally accepted that it's useful, and I'm a little dubious because it does hide argument count in functions where it's used, the 6 #defines should be centralized in kernel.h $ git grep "define.*ARRAY_AND_SIZE" arch/arm/mach-kirkwood/common.h:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) arch/arm/mach-mmp/common.h:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) arch/arm/mach-pxa/generic.h:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) arch/arm/mach-ux500/db8500-regs.h:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) drivers/pinctrl/pinctrl-lantiq.h:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) sound/soc/pxa/mioa701_wm9713.c:#define ARRAY_AND_SIZE(x) (x), ARRAY_SIZE(x) A small counter-argument against using ARRAY_AND_SIZE: clkdev_add_table has 60+ uses, only 6 of those with ARRAY_AND_SIZE. I think it makes it difficult to do some cocinelle/spatch transform on clkdev_add_table. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
