re: pktcdvd: add struct pktcdvd_device * to pkt_dbg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Joe Perches,

This is a semi-automatic email about new static checker warnings.

The patch 3567318a63ff: "pktcdvd: add struct pktcdvd_device * to 
pkt_dbg" from Aug 1, 2013, leads to the following Smatch complaint:

drivers/block/pktcdvd.c:2844 pkt_remove_dev()
	 error: we previously assumed 'pd' could be null (see line 2840)

drivers/block/pktcdvd.c
  2839			pd = pkt_devs[idx];
  2840			if (pd && (pd->pkt_dev == pkt_dev))
                            ^^
Old check.

  2841				break;
  2842		}
  2843		if (idx == MAX_WRITERS) {
  2844			pkt_dbg(1, pd, "dev not setup\n");
                                   ^^
New dereference.

  2845			ret = -ENXIO;
  2846			goto out;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux